Yemachu

Used a computer which has Edge on it to try figure out where downloading goes wrong. The debug tools are unfortunately somewhat lackluster, which is not helped by the minification that is performed on application (done for slightly faster load times), so I don't know where it goes wrong. Though I have managed to confirm that the host address does not affect the ability to download the data. 

While this issue is being sorted out, I'd suggest that users of Edge (temporarily) switch to a browser like Firefox or Chrome. Otherwise rely on the auto-saving feature.

I'm locking this topic, as it has served its purpose. Please start a different topic if you encounter another issue.

While some things have changed in the code, none of it relates to downloading. That isn't to say I have no idea what might be causing it. Prior to the incorporation of the card maker, the code was hosted under the same domain as the webpage that loads it. Nowadays this is different; the code is still in the same place as it used to be, but the page requesting the code isn't. 

It isn't a vulnerability in this specific case, but could be considered one in the general case. A browser could very well decide to block any attempt to download data that as initiated by a script that is not provided by the current domain. For all we know it was a malicious advertisement.

But this is just a hunch; it needs to be tested to be sure. Could you test whether the download functionality still works for the old location? (https://yemachu.github.io/cardmaker/). If it doesn't work there, I unfortunately don't know what to do either.

Which browsers are supported, and which ones aren't is not quite clear cut. Not all browsers support the same features; it might be that I relied on one that is not supported by Edge in this case. Firefox is my browser of choice; since I don't usually test with all of the major browsers, issues like these might slip through.

I don't know the exact issue, so it is something that I will have to look into. In the meantime you could try using a different browser, or rely on the autosave functionality (though it isn't all that useful when working on different cards).

The card maker is, and was, not supposed to take you to a different page when you try to save your card. Though it is a known issue that some browsers show a file instead of downloading it. My best guess would be that your browser now behaves correctly, by downloading the file. Could you check if your Downloads folder contains a file that might come from the card maker?

Some time ago "Yu-Gi-Oh! Sevens" was announced, introducing a new layout for cards. As far as I'm aware, only effect monsters have been shown (aside from "Blue-Eyes White Dragon" under an angle which makes it hard to use). So I had to take some liberties when it comes to the other templates.

It will take some time before these templates are implemented in the card maker, but you should be able to play around with them in your favorite image editor (like Krita, Gimp, Photoshop, etc.).

Some work is being done to better incorporate the card maker in this website. A few changes were required, which could have broken other things. I don't encounter the issue myself, so I have little to go of what could be causing the issue. It could be a caching issue. Maybe that clearing it helps.

• Clear cache under FireFox
• Clear cache under Chrome
• Clear cache under Edge

If that does not work, I will need some more information to work with. Like the browser where this occurs, and maybe a screenshot of the console (typically opened using F12).

Better incorporating the card maker into this site would indeed be very cool, but I'd also like to have it still stand alone. Either way, some discussion is needed about how to incorporate it.

Having buttons and text fields follow the theme the user has selected would go a long way. The layout would probably also need a rework, but that was already the case because of the different features I have been working on.

Other than some card maker related stuff, I haven't really been all that active on the forum. Aside from Duel Links, I don't really play the game all that much anymore, so my knowledge about cards and combos is limited. Which means I have little to add ro the card discussion, and card creation topics. 

In any case, it is nice to see how the site has evolved.

In order to generate "silver" and "gold" colored text, the card maker renders the same text twice (with a different offset each time). It does the job to a certain extend, but it is very limited in what it can do.

In this experiment I have tried to render text with a gradient overlay and inner text shadow. The result is maybe a bit over the top, but it should give an impression of what is possible. It needs some fine-tuning before it gets incorporated in the card maker.

Expirement: Text replacement macros

The card maker provides a number of customizable fields. Some users might want to use the value they assigned to one of those fields in another one. For example when referring to the card's name in its effect. This can be done by simply copying the value, but it is easy for the values to get out of sync.

This experiment showcases string substitution which should solve the above issue in a slightly more elegant way. The substitution is performed by looking for piece of text enclosed by square brackets. In this case an at-sign followed by the name of the fiekd to include. In this example this means: [@name] or [@type]. The syntax is not yet finalized though. (if no text fields show up, I probably made a mistake somewhere in the code).

Rework how monster types are edited

Some of the cards that have been generated by the card maker show the wrong card type (Ritual / Fusion / Synchro / etc.). This is hardly surprising, as this is something that needs to be updated manually each time the card type is changed.

Considering some people seem to like creating cards in different languages, as well as adding (custom) sub-types, it is not ideal to simply append the card's type to the user's input. This would cause the text to appear in the wrong order.

7 hours ago, Zeddle said:

A thing I always wished to get improved is the effect text. For short effects its perfect, but if I have a long effect the space between the text and the becomes unnecessarily large and the text gets pressed together. Here an example:

I'm not sure if or how it could be fixed. But that's a thing that always annoyed me.

It is indeed a shame that the card maker behaves that way. I'm not quite sure what is causing it, as I haven't really looked into it all that much yet. But my guess is as follows:

A bigger font size causes words to be wider. As a result, there can not be as many words on a single line, which means the effect would take a line or two more. As each of those lines is also higher, the text might not fit in the box, if only by a pixel.

In any case, I will add it to the list.

Add a project manager to the card maker

Some users wish to work on a set of cards. Switching between different cards in the set can be tedious with the current implementation of the card maker; the card being edited needs to be downloaded before opening another card. Besides being time consuming, this method is also error prone, as forgetting to save the card before opening another results in a loss of work.

3 hours ago, Lord of Shadows said:

Hope this is right place for my idea/request, but can the option to add the different edition types please be added to the cardmaker
(and the option to choose where it goes like on left side of card from the set id # or on the bottom to the right of the card id# i personally prefer the location where its on the left side of the card on the same line as the set id #)

for example:
 • Limited Edition
 • 1st Edition
 

This is indeed the correct thread for providing those suggestions.

There are some issues with the position of the circulation, which is why it is not implemented (yet). If the circulation is located at the bottom of the card, its location is somewhat based on the serial number. Due to the variable width of said component, there it is somewhat hard to place the circulation.

Placing the circulation on the left side below the image (like the older cards) would make it easier, but this doesn't quite work for Pendulum cards.

The current plan is to only implement the circulation for non-Pendulum cards. Though I'm not certain how to go about the different fonts for "1st Edition" and "Duel terminal". Having the fonts as options in a dropwdown is probably the easiest option while maintaining the freedom to think of a different circulation.

3 hours ago, Tormented said:

@Yemachu Can you update the Card Maker link to NCM, please? It's still pointing at /forum instead of https://neocardmaker.com (I appreciate this change has taken place short notice!)

The link has been updated.

Somewhat tempted to join as well. But I won't as I expect to be quite inactive, which is not ideal for a monster. Then there is the fact that I'm probably not known all that well outside creating this site's card maker. This would make it either quite hard to link my identity (little information to go off), or rather easy (due to being the most likely member to incorporate programming in some form for interaction).

But I might be able to help out with the event by providing some scripts which do... stuff. But given the time constraints (for this year) it most likely won't be all that special. Maybe a simple game like pong, snake or something of the kind which provides a clue when the user reaches a certain threshold.

5 hours ago, ragnaryg said:

Suggestions:

-Adding Ultra Rare as a Rarity (at least the golden letters, if possible, I read that the optical effects would be quite hard)

- Adding a randomizer for the Serial Number

 

Other than that, I find your card maker absolutely flawless. I have no problem with the "type"-editing (it allows me from Germany to use the German words), and I find it incredibly useful to be able to easily download the .json file. Also a huge thanks for the pendulum-area - to be able to create about any card type with pendulum options really gives way to some cool possibilities. I do have a problem with the fonts when I'm using my laptop, but that's more of an personal hindrance and with the .json-files one that can be easily solved

Golden letters should be easy to add (when I have access to my computer; currently on vacation using my phone). Adding the optical effect isn't hard in terms of programming, but I need an image I can overlay that provides a believable effect. Creating such an image is where I'm somewhat stuck. Certain rarities also have an pattern that is influenced by the image; there are no plans fpr implementing such a feature.

Serial number randomization shouldn't be a big deal either (though they might overlap with existing cards). Will probably add it in the next update.

Regarding the json, the idea is to store the data in the downloaded image using a technique called stenography. In that case someone could continue working on their card by opening it again. There are however some issues with the amount of data that can be saved.

As for the card types, I don't intend to force it upon the user. I was thinking more along the lines of having checkboxes for the various sub-types (Tuner, Union, Effect, etc.), which get automaticlly appended in the correct order. This would include the card's type (and its pendulumness, which will probably share their checkbox). By not checking any of the boxes, it would function the same as it currently does. Though I'm not quite sure what to do in the case of Effect monsters, as two checkboxes could be responsible for adding the "effect" part.

Could upload image generated with your laptop (or a screenshot) so that I can get a better idea of what font related issue occurs? I have some ideas what the issue might be, but your description is currently quite vague.

Suggestions so far:

• Upload the generated card straight to an image hosting platform (for example: Imgur).
• Update the card maker's templates to match the series 10 template (rectangular around the card's name).
• Let the "Save" button download the generated card, as opposed to a .json file.
• Rework the way "Types" are edited. Changing a Synchro monster to a Fusion monster doesn't update the type automatically for example.
• Make it possible to edit the card's circulation ("1st Edition", "Duel terminal") .
• Add a project manager to the card maker .
• Add a button to randomize the serial number . v1.1.6
• Rework the auto resizing effect text so it no longer shrinks more than it needs . v1.1.7

The card maker makes it somewhat easy to create custom cards. It isn't flawless however, either due to missing features or poorly executed ones.

This topic is used to keep track of the community's suggestions for improving the card maker.

So what do you think can be improved on?

Some more new Pokémon have been revealed, as well as a new concept called "Gigantamaxing". Which is basically Dynamax which also changes the shape of the Pokémon. It seems thee are some Version exclusive gym leaders as well.

The rendered image is actually a canvas element. That type of element allows for code to draw images and text onto it, but not all browsers provide an easy way to download the contents of said canvas. You might be able to download the image by simply clicking on it with the left mouse button, or tapping it (depending on the device).

There are plans for improving on a variety of issues that people have brought up, like saving the image. I'm unfortunately somewhat short on time.

Alternatively, you can simply click (or tap if using a touchscreen) the generated image. That should prompt a download of the image. Given this question comes up every so often, I intend to make a future version of the download the image with the data encoded in it (through steganography), instead of a .json file.

Finding the time to work on the different issues/features is currently one of the biggest problems.

9 hours ago, Persephone Diggen said:

hi, why there are only common, rare and secret rare cards? when are you going to put the other rarities? I have another question, why types of monsters in the same place with spell and trap cards? they need to be separate from each other, every monster type in one place and the spells and traps types in another place, do you understand what I'm trying to say? I hope so

Q: Why are there only common, rare and secret rare cards?

A: Certain rarities have little that sets them apart from the others, so I didn't really feel the need to add more than the ones that are currently supported. There is also the point of creating a convincing foil effect for the ultra rare cards, which is probably harder than secret rare (where the specks are the defining feature).

The other rarities migt be added once I have figured out how to create an effect that conveys the rarity in question. 

Q: Why are monster types in the same place as spell and trap cards?

I take it you are referring to the input field which is used for inputting "Spell Card", "Trap Card", "Aqua / Effect" and so on. Given they both refer to the type of card, and aren't present at the same time as eachother, I felt the textfield could be reused. The interface is already somewhat cluttered, so I wanted to keep it down a bit.

You could argue that the option to set the card type is not needed in case of Spell/Trap cards, but there is somewhat of a precedent in the form of "Magic Cards" (that type was used for Spell Cards early in the game, the change was probably made due to Magic the Gathering). Providing the option didn't take all that much effort, and allows for creating cards in a foreign language as well (the Attribute will display the wrong name though).

This thread is used for testing tags and styling them, among other things. With the eventual goal of integrating the card maker in this site, instead of putting it in a sandbox. Some stuff might thus look out of place.

The requested Pendulum Link monster template has been added to the card maker, albeit with a slightly different layout. Have fun with it!

(Pendulum Spell and Trap cards have been added in the same update as well).

2 hours ago, Shradow said:

I love all the starters, dunno which I want yet.

I'm also super curious about that big Nazca Lines looking thing on the hillside, I'm assuming it has to do with the mythology/Legendary Pokemon of the region.

They could be Hill figures, which are mostly found in England, if I'm not mistaken. Which is fitting for a region based on England. 

Out of the starters I like Grookey most, followed by Sobble. Not really a fan of Scorbunny though. It might change with their evolutions.

The graphics of the game look nice, from what we've seen so far.